Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Fix - storage popover margins#546

Open
nico3333fr wants to merge 2 commits intomasterfrom
fix/storagePopoverCloseMargins
Open

Fix - storage popover margins#546
nico3333fr wants to merge 2 commits intomasterfrom
fix/storagePopoverCloseMargins

Conversation

@nico3333fr
Copy link
Contributor

@nico3333fr nico3333fr commented Jan 30, 2020

Short description of what this resolves:

The margin on Close button on storage popover was not the same as for other popovers/modals (spotted by QA jedis)

Changes proposed in this pull request:

  • set it up to exact same values as for modals/popovers
  • bonus, added a text for better a11y (empty buttons are badly vocalized)

Snapshot

image

Co-Authored-By: Richard <EpokK@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants